Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: listen on the IPv6 unspecified address #861

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix: listen on the IPv6 unspecified address #861

merged 1 commit into from
Sep 23, 2024

Conversation

michaelbeaumont
Copy link
Contributor

This is a step towards making mayastor work on dual-stack/ipv6-only clusters.

@tiagolobocastro
Copy link
Contributor

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Sep 16, 2024
Try #861:
5fb7fdf
@bors-openebs-mayastor
Copy link

try

Build failed:

@tiagolobocastro
Copy link
Contributor

hmm rest client test keeps butting heads with jaeger service:

client:
OpenTelemetry trace error occurred. Exporter otlp encountered the following error(s): the grpc server returns error (Unknown error): , detailed error message: transport error
.....
jaeger service:
{"level":"info","ts":1726278455.7668839,"caller":"[email protected]/server.go:984","msg":"[core][Server #2]grpc: Server.Serve failed to create ServerTransport: connection error: desc = \"transport: http2Server.HandleStreams received bogus greeting from client: \\\"\\\\x03\\\\x00\\\\x00/*\\\\xe0\\\\x00\\\\x00\\\\x00\\\\x00\\\\x00Cookie: mstsh\\\"\"","system":"grpc","grpc_log":true}

Let's retry again, otherwise maybe we need to disable jaeger for this test until get to the bottom of it...
bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Sep 16, 2024
Try #861:
e72b572
@bors-openebs-mayastor
Copy link

try

Build succeeded:

@tiagolobocastro
Copy link
Contributor

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Sep 18, 2024
@michaelbeaumont
chore(bors): merge pull request #861
144038a 
861: fix: listen on the IPv6 unspecified address r=tiagolobocastro a=michaelbeaumont

This is a step towards making mayastor work on dual-stack/ipv6-only clusters.

Co-authored-by: Mike Beaumont <[email protected]>
@bors-openebs-mayastor
Copy link

Build failed:

@tiagolobocastro
Copy link
Contributor

@dsharma-dc seems bors is failing due to the recent nvmf changes, could you please take a look?

@dsharma-dc
Copy link
Contributor

dsharma-dc commented Sep 23, 2024 •
edited
Loading

@dsharma-dc seems bors is failing due to the recent nvmf changes, could you please take a look?

Checking this. Some tests need adjustments. They didn't fail earlier in CI because io-engine PR was merged after control-plane.

@dsharma-dc
Copy link
Contributor

@michaelbeaumont Could you please rebase your branch on develop and we'll try merging again.

@tiagolobocastro
Copy link
Contributor

@michaelbeaumont Could you please rebase your branch on develop and we'll try merging again.

Not necessary, bors deals with this as long as there's no conflict.
bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 656e8ff into openebs:develop Sep 23, 2024
4 checks passed
@michaelbeaumont michaelbeaumont deleted the fix/ipv6-listen-any branch September 23, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelbeaumont @tiagolobocastro @dsharma-dc @Abhinandan-Purkait